Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs> (Closed)

Created:
3 years, 9 months ago by mrunal
Modified:
3 years, 9 months ago
Reviewers:
tkent, eae
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, zoltan1, rwlbuis, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, fmalita+watch_chromium.org, fs, krit, jchaffraix+rendering, blink-reviews, gyuyoung2, Stephen Chennney, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERT with DCHECK in core/layout/<sub dirs> Next patch should cover files in core/layout/ itself. BUG=697685 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2748103015 Cr-Commit-Position: refs/heads/master@{#459988} Committed: https://chromium.googlesource.com/chromium/src/+/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39

Patch Set 1 #

Patch Set 2 : Rebase on top of latest #

Patch Set 3 : Convert enum to unsigned to satisfy Windows build #

Patch Set 4 : Add #if DCHECK_IS_ON() to satisfy chromeos build #

Patch Set 5 : Move #if DCHECK_IS_ON inside parent() #

Patch Set 6 : Rebase with latest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+376 lines, -363 lines) Patch
M third_party/WebKit/Source/core/layout/api/LineLayoutSVGInlineText.h View 2 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 2 3 4 5 19 chunks +25 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp View 1 2 3 4 5 11 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineBox.h View 1 2 3 4 5 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineBox.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp View 10 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineIterator.h View 5 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineTextBox.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp View 1 2 3 7 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineBoxList.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineBreaker.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineWidth.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/RootInlineBox.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/TrailingObjects.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/TrailingObjects.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/shapes/BoxShape.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/shapes/PolygonShape.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/shapes/RasterShape.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/shapes/RasterShape.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/shapes/RectangleShape.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/shapes/Shape.cpp View 1 2 3 4 5 5 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/shapes/ShapeInterval.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.cpp View 1 2 3 4 5 6 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGEllipse.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGPath.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.cpp View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp View 6 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp View 10 chunks +24 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGTransformableContainer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp View 1 2 3 4 5 8 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutTreeAsText.cpp View 1 2 3 4 5 6 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGResources.cpp View 1 2 3 4 5 19 chunks +38 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGResourcesCache.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGResourcesCycleSolver.cpp View 1 2 3 4 5 6 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextChunkBuilder.cpp View 1 2 3 4 5 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp View 9 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineBaseline.cpp View 1 2 3 4 5 4 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineSpacing.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextQuery.cpp View 1 2 3 4 5 8 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp View 1 2 3 4 5 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
mrunal
eae,tkent, PTAL.
3 years, 9 months ago (2017-03-18 01:21:26 UTC) #4
eae
LGTM
3 years, 9 months ago (2017-03-18 20:19:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748103015/1
3 years, 9 months ago (2017-03-18 20:19:42 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_tests_slimming_paint_v2/builds/3330)
3 years, 9 months ago (2017-03-18 20:35:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748103015/40001
3 years, 9 months ago (2017-03-22 21:57:44 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/303996)
3 years, 9 months ago (2017-03-22 22:33:42 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748103015/100001
3 years, 9 months ago (2017-03-27 23:24:53 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-03-28 02:17:09 UTC) #20
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/7cd03f7e88b6e5d1f98d44c1fa01...

Powered by Google App Engine
This is Rietveld 408576698