Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Unified Diff: third_party/WebKit/Source/core/layout/api/LineLayoutSVGInlineText.h

Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs> (Closed)
Patch Set: Rebase with latest Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/api/LineLayoutSVGInlineText.h
diff --git a/third_party/WebKit/Source/core/layout/api/LineLayoutSVGInlineText.h b/third_party/WebKit/Source/core/layout/api/LineLayoutSVGInlineText.h
index 483575d0debcd4f27bdca79890de77a0a67f2e11..01db194a18fddb252088fae2fcb5893e705e20dc 100644
--- a/third_party/WebKit/Source/core/layout/api/LineLayoutSVGInlineText.h
+++ b/third_party/WebKit/Source/core/layout/api/LineLayoutSVGInlineText.h
@@ -62,10 +62,10 @@ class SVGInlineTextMetricsIterator {
void advanceToTextStart(LineLayoutSVGInlineText textLineLayout,
unsigned startCharacterOffset) {
- ASSERT(textLineLayout);
+ DCHECK(textLineLayout);
if (!m_textLineLayout || m_textLineLayout != textLineLayout) {
reset(textLineLayout);
- ASSERT(!metricsList().isEmpty());
+ DCHECK(!metricsList().isEmpty());
}
if (m_characterOffset == startCharacterOffset)
@@ -78,18 +78,19 @@ class SVGInlineTextMetricsIterator {
while (m_characterOffset < startCharacterOffset)
next();
- ASSERT(m_characterOffset == startCharacterOffset);
+ DCHECK_EQ(m_characterOffset, startCharacterOffset);
}
void next() {
m_characterOffset += metrics().length();
- ASSERT(m_characterOffset <= m_textLineLayout.length());
- ASSERT(m_metricsListOffset < metricsList().size());
+ DCHECK_LE(m_characterOffset, m_textLineLayout.length());
+ DCHECK_LT(m_metricsListOffset, metricsList().size());
++m_metricsListOffset;
}
const SVGTextMetrics& metrics() const {
- ASSERT(m_textLineLayout && m_metricsListOffset < metricsList().size());
+ DCHECK(m_textLineLayout);
+ DCHECK_LT(m_metricsListOffset, metricsList().size());
return metricsList()[m_metricsListOffset];
}
const Vector<SVGTextMetrics>& metricsList() const {
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698