third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp - Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp

Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs> (Closed)

Patch Set: Rebase with latest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp

index 8c7e618aed508cf3e7b9d674a10ab9e04e803d72..8ad96bdf047ca318961d49ab355e3ff593cc5cbb 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp

@@ -38,7 +38,8 @@ PathPositionMapper::PositionType PathPositionMapper::pointAndNormalAtLength(

return BeforePath;

if (length > m_pathLength)

return AfterPath;

- ASSERT(length >= 0 && length <= m_pathLength);

+ DCHECK_GE(length, 0);

+ DCHECK_LE(length, m_pathLength);

m_positionCalculator.pointAndNormalAtLength(length, point, angle);

return OnPath;

}