Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGTransformableContainer.cpp

Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs> (Closed)
Patch Set: Rebase with latest Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGTransformableContainer.cpp
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGTransformableContainer.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGTransformableContainer.cpp
index 8d1af96c79bd28dcf912a58f18c4695c8e8f6268..7c9bfd001c0f0295790b91e63f1d3d10a007e29c 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGTransformableContainer.cpp
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGTransformableContainer.cpp
@@ -33,7 +33,7 @@ LayoutSVGTransformableContainer::LayoutSVGTransformableContainer(
: LayoutSVGContainer(node), m_needsTransformUpdate(true) {}
static bool hasValidPredecessor(const Node* node) {
- ASSERT(node);
+ DCHECK(node);
for (node = node->previousSibling(); node; node = node->previousSibling()) {
if (node->isSVGElement() && toSVGElement(node)->isValid())
return true;
@@ -44,7 +44,7 @@ static bool hasValidPredecessor(const Node* node) {
bool LayoutSVGTransformableContainer::isChildAllowed(
LayoutObject* child,
const ComputedStyle& style) const {
- ASSERT(element());
+ DCHECK(element());
if (isSVGSwitchElement(*element())) {
Node* node = child->node();
// Reject non-SVG/non-valid elements.
@@ -77,7 +77,7 @@ void LayoutSVGTransformableContainer::setNeedsTransformUpdate() {
SVGTransformChange LayoutSVGTransformableContainer::calculateLocalTransform() {
SVGGraphicsElement* element = toSVGGraphicsElement(this->element());
- ASSERT(element);
+ DCHECK(element);
// If we're either the layoutObject for a <use> element, or for any <g>
// element inside the shadow tree, that was created during the use/symbol/svg

Powered by Google App Engine
This is Rietveld 408576698