Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp

Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs> (Closed)
Patch Set: Rebase with latest Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp b/third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp
index c1b9863fcee8de311aa6baf360c8d28153228b4a..098a7461b14abf0d68e09da9e2772cbd1b3d3471 100644
--- a/third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp
+++ b/third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp
@@ -72,8 +72,8 @@ void AbstractInlineTextBox::willDestroy(InlineTextBox* inlineTextBox) {
}
AbstractInlineTextBox::~AbstractInlineTextBox() {
- ASSERT(!m_lineLayoutItem);
- ASSERT(!m_inlineTextBox);
+ DCHECK(!m_lineLayoutItem);
+ DCHECK(!m_inlineTextBox);
}
void AbstractInlineTextBox::detach() {
@@ -88,7 +88,7 @@ void AbstractInlineTextBox::detach() {
PassRefPtr<AbstractInlineTextBox> AbstractInlineTextBox::nextInlineTextBox()
const {
- ASSERT(!m_inlineTextBox ||
+ DCHECK(!m_inlineTextBox ||
!m_inlineTextBox->getLineLayoutItem().needsLayout());
if (!m_inlineTextBox)
return nullptr;
@@ -180,19 +180,19 @@ String AbstractInlineTextBox::text() const {
}
bool AbstractInlineTextBox::isFirst() const {
- ASSERT(!m_inlineTextBox ||
+ DCHECK(!m_inlineTextBox ||
!m_inlineTextBox->getLineLayoutItem().needsLayout());
return !m_inlineTextBox || !m_inlineTextBox->prevTextBox();
}
bool AbstractInlineTextBox::isLast() const {
- ASSERT(!m_inlineTextBox ||
+ DCHECK(!m_inlineTextBox ||
!m_inlineTextBox->getLineLayoutItem().needsLayout());
return !m_inlineTextBox || !m_inlineTextBox->nextTextBox();
}
PassRefPtr<AbstractInlineTextBox> AbstractInlineTextBox::nextOnLine() const {
- ASSERT(!m_inlineTextBox ||
+ DCHECK(!m_inlineTextBox ||
!m_inlineTextBox->getLineLayoutItem().needsLayout());
if (!m_inlineTextBox)
return nullptr;
@@ -207,7 +207,7 @@ PassRefPtr<AbstractInlineTextBox> AbstractInlineTextBox::nextOnLine() const {
PassRefPtr<AbstractInlineTextBox> AbstractInlineTextBox::previousOnLine()
const {
- ASSERT(!m_inlineTextBox ||
+ DCHECK(!m_inlineTextBox ||
!m_inlineTextBox->getLineLayoutItem().needsLayout());
if (!m_inlineTextBox)
return nullptr;

Powered by Google App Engine
This is Rietveld 408576698