Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs> (Closed)
Patch Set: Rebase with latest Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h
diff --git a/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h b/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h
index 9a184446e5a2441af22202ec213b0ad80d62ca2a..7893a3b065aee291e182fa5392fabb9bd62eb5ab 100644
--- a/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h
+++ b/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h
@@ -300,7 +300,7 @@ inline bool requiresLineBox(
inline void setStaticPositions(LineLayoutBlockFlow block,
LineLayoutBox child,
IndentTextOrNot indentText) {
- ASSERT(child.isOutOfFlowPositioned());
+ DCHECK(child.isOutOfFlowPositioned());
// FIXME: The math here is actually not really right. It's a best-guess
// approximation that will work for the common cases
LineLayoutItem containerBlock = child.container();
@@ -552,7 +552,7 @@ inline bool shouldSkipWhitespaceAfterStartObject(
inline void BreakingContext::handleEmptyInline() {
// This should only end up being called on empty inlines
- ASSERT(m_current.getLineLayoutItem());
+ DCHECK(m_current.getLineLayoutItem());
LineLayoutInline flowBox(m_current.getLineLayoutItem());
@@ -982,7 +982,7 @@ inline bool BreakingContext::handleText(WordMeasurements& wordMeasurements,
if (layoutText.isWordBreak()) {
m_width.commit();
m_lineBreak.moveToStartOf(m_current.getLineLayoutItem());
- ASSERT(m_current.offset() == layoutText.textLength());
+ DCHECK_EQ(m_current.offset(), layoutText.textLength());
}
if (m_layoutTextInfo.m_text != layoutText) {

Powered by Google App Engine
This is Rietveld 408576698