Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineBox.h

Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs> (Closed)
Patch Set: Rebase with latest Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/line/InlineBox.h
diff --git a/third_party/WebKit/Source/core/layout/line/InlineBox.h b/third_party/WebKit/Source/core/layout/line/InlineBox.h
index 0baa80065f3d3d5da5bf2ed255afc69e30d373c0..b135f43bd9dba0f695a8f1fe163dcc426f99d428 100644
--- a/third_party/WebKit/Source/core/layout/line/InlineBox.h
+++ b/third_party/WebKit/Source/core/layout/line/InlineBox.h
@@ -182,11 +182,11 @@ class CORE_EXPORT InlineBox : public DisplayItemClient {
InlineBox* nextOnLine() const { return m_next; }
InlineBox* prevOnLine() const { return m_prev; }
void setNextOnLine(InlineBox* next) {
- ASSERT(m_parent || !next);
+ DCHECK(m_parent || !next);
m_next = next;
}
void setPrevOnLine(InlineBox* prev) {
- ASSERT(m_parent || !prev);
+ DCHECK(m_parent || !prev);
m_prev = prev;
}
@@ -205,9 +205,12 @@ class CORE_EXPORT InlineBox : public DisplayItemClient {
LineLayoutItem getLineLayoutItem() const { return m_lineLayoutItem; }
InlineFlowBox* parent() const {
- ASSERT(!m_hasBadParent);
+#if DCHECK_IS_ON()
+ DCHECK(!m_hasBadParent);
+#endif
return m_parent;
}
+
void setParent(InlineFlowBox* par) { m_parent = par; }
const RootInlineBox& root() const;

Powered by Google App Engine
This is Rietveld 408576698