third_party/WebKit/Source/core/layout/line/RootInlineBox.h - Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/RootInlineBox.h

Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs> (Closed)

Patch Set: Rebase with latest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/line/RootInlineBox.h

diff --git a/third_party/WebKit/Source/core/layout/line/RootInlineBox.h b/third_party/WebKit/Source/core/layout/line/RootInlineBox.h

index 1567b093eb95d099a69653b8dddde0c925aafc8e..98bcb74ae7ee2cf180bd01933e20b91dfe8e30e7 100644

--- a/third_party/WebKit/Source/core/layout/line/RootInlineBox.h

+++ b/third_party/WebKit/Source/core/layout/line/RootInlineBox.h

@@ -158,7 +158,7 @@ class RootInlineBox : public InlineFlowBox {

bool onlyEditableLeaves = false);

void appendFloat(LayoutBox* floatingBox) {

- ASSERT(!isDirty());

+ DCHECK(!isDirty());

if (m_floats)

m_floats->push_back(floatingBox);

else

@@ -166,7 +166,7 @@ class RootInlineBox : public InlineFlowBox {

}

Vector<LayoutBox*>* floatsPtr() {

- ASSERT(!isDirty());

+ DCHECK(!isDirty());

return m_floats.get();

}