third_party/WebKit/Source/core/layout/line/LineWidth.cpp - Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/LineWidth.cpp

Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs> (Closed)

Patch Set: Rebase with latest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/line/LineWidth.cpp

diff --git a/third_party/WebKit/Source/core/layout/line/LineWidth.cpp b/third_party/WebKit/Source/core/layout/line/LineWidth.cpp

index 567d9cc68ab89e3730f7b6b469369bb9760a4c8f..bb39a543a158442f7f1e0f92cf821d10eb4c6ffb 100644

--- a/third_party/WebKit/Source/core/layout/line/LineWidth.cpp

+++ b/third_party/WebKit/Source/core/layout/line/LineWidth.cpp

@@ -189,8 +189,8 @@ void LineWidth::wrapNextToShapeOutside(bool isFirstLine) {

}

void LineWidth::fitBelowFloats(bool isFirstLine) {

- ASSERT(!m_committedWidth);

- ASSERT(!fitsOnLine());

+ DCHECK(!m_committedWidth);

+ DCHECK(!fitsOnLine());

m_block.placeNewFloats(m_block.logicalHeight(), this);

LayoutUnit floatLogicalBottom;