Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp

Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs> (Closed)
Patch Set: Rebase with latest Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp
index 38e0dc2ed1a4f975cda91bfdc25b1fd27197aad4..0d981642f2a0e3ab7b10888deb337c3078eb1f1e 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp
@@ -32,7 +32,7 @@ LayoutSVGResourceMarker::LayoutSVGResourceMarker(SVGMarkerElement* node)
LayoutSVGResourceMarker::~LayoutSVGResourceMarker() {}
void LayoutSVGResourceMarker::layout() {
- ASSERT(needsLayout());
+ DCHECK(needsLayout());
if (m_isInLayout)
return;
@@ -55,7 +55,7 @@ void LayoutSVGResourceMarker::removeAllClientsFromCache(
void LayoutSVGResourceMarker::removeClientFromCache(LayoutObject* client,
bool markForInvalidation) {
- ASSERT(client);
+ DCHECK(client);
markClientForInvalidation(client, markForInvalidation
? BoundariesInvalidation
: ParentOnlyInvalidation);
@@ -74,7 +74,7 @@ FloatRect LayoutSVGResourceMarker::markerBoundaries(
FloatPoint LayoutSVGResourceMarker::referencePoint() const {
SVGMarkerElement* marker = toSVGMarkerElement(element());
- ASSERT(marker);
+ DCHECK(marker);
SVGLengthContext lengthContext(marker);
return FloatPoint(marker->refX()->currentValue()->value(lengthContext),
@@ -123,7 +123,7 @@ AffineTransform LayoutSVGResourceMarker::markerTransformation(
bool LayoutSVGResourceMarker::shouldPaint() const {
// An empty viewBox disables rendering.
SVGMarkerElement* marker = toSVGMarkerElement(element());
- ASSERT(marker);
+ DCHECK(marker);
return !marker->viewBox()->isSpecified() ||
!marker->viewBox()->currentValue()->isValid() ||
!marker->viewBox()->currentValue()->value().isEmpty();
@@ -144,7 +144,7 @@ SVGTransformChange LayoutSVGResourceMarker::calculateLocalTransform() {
return SVGTransformChange::None;
SVGMarkerElement* marker = toSVGMarkerElement(element());
- ASSERT(marker);
+ DCHECK(marker);
SVGLengthContext lengthContext(marker);
float width = marker->markerWidth()->currentValue()->value(lengthContext);

Powered by Google App Engine
This is Rietveld 408576698