third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.cpp - Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.cpp

Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs> (Closed)

Patch Set: Rebase with latest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.cpp

index 7d1df3750e1e4dd19e07013cde2602fd1ea3cc96..d8e4fcece05b52a9546b9471630b5f73cf6e59d1 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.cpp

@@ -45,7 +45,7 @@ void LayoutSVGResourceMasker::removeAllClientsFromCache(

void LayoutSVGResourceMasker::removeClientFromCache(LayoutObject* client,

bool markForInvalidation) {

- ASSERT(client);

+ DCHECK(client);

markClientForInvalidation(client, markForInvalidation

? BoundariesInvalidation

: ParentOnlyInvalidation);

@@ -112,7 +112,7 @@ void LayoutSVGResourceMasker::calculateMaskContentVisualRect() {

FloatRect LayoutSVGResourceMasker::resourceBoundingBox(

const LayoutObject* object) {

SVGMaskElement* maskElement = toSVGMaskElement(element());

- ASSERT(maskElement);

+ DCHECK(maskElement);

FloatRect objectBoundingBox = object->objectBoundingBox();

FloatRect maskBoundaries = SVGLengthContext::resolveRectangle<SVGMaskElement>(