third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.h - Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.h

Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs> (Closed)

Patch Set: Rebase with latest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.h

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.h b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.h

index ce52519b147d1bd80cc2621aecc73e60f153188a..d9da64f3b93a03e3ba27bc47c096fc04870ea41f 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.h

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.h

@@ -80,7 +80,7 @@ struct SVGPaintDescription {

: resource(nullptr), color(color), isValid(true), hasFallback(false) {}

SVGPaintDescription(LayoutSVGResourcePaintServer* resource)

: resource(resource), isValid(true), hasFallback(false) {

- ASSERT(resource);

+ DCHECK(resource);

}

SVGPaintDescription(LayoutSVGResourcePaintServer* resource,

Color fallbackColor)

@@ -88,7 +88,7 @@ struct SVGPaintDescription {

color(fallbackColor),

isValid(true),

hasFallback(true) {

- ASSERT(resource);

+ DCHECK(resource);

}

LayoutSVGResourcePaintServer* resource;