third_party/WebKit/Source/core/layout/shapes/RectangleShape.cpp - Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/shapes/RectangleShape.cpp

Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs> (Closed)

Patch Set: Rebase with latest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/shapes/RectangleShape.cpp

diff --git a/third_party/WebKit/Source/core/layout/shapes/RectangleShape.cpp b/third_party/WebKit/Source/core/layout/shapes/RectangleShape.cpp

index 4e6fb896d94269febf458e9c1caa4d8ed55e88c5..4a4a535dbc83fa3fe0d873430223c31242bc9d79 100644

--- a/third_party/WebKit/Source/core/layout/shapes/RectangleShape.cpp

+++ b/third_party/WebKit/Source/core/layout/shapes/RectangleShape.cpp

@@ -34,12 +34,12 @@

namespace blink {

static inline float ellipseXIntercept(float y, float rx, float ry) {

- ASSERT(ry > 0);

+ DCHECK_GT(ry, 0);

return rx * sqrt(1 - (y * y) / (ry * ry));

}

FloatRect RectangleShape::shapeMarginBounds() const {

- ASSERT(shapeMargin() >= 0);

+ DCHECK_GE(shapeMargin(), 0);

if (!shapeMargin())

return m_bounds;