Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Side by Side Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilter.cpp

Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs> (Closed)
Patch Set: Rebase with latest Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>
4 * Copyright (C) 2005 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2005 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org> 5 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 // all clients through markAllClientsForInvalidation so no explicit 66 // all clients through markAllClientsForInvalidation so no explicit
67 // display item invalidation is needed here. 67 // display item invalidation is needed here.
68 disposeFilterMap(); 68 disposeFilterMap();
69 markAllClientsForInvalidation(markForInvalidation 69 markAllClientsForInvalidation(markForInvalidation
70 ? LayoutAndBoundariesInvalidation 70 ? LayoutAndBoundariesInvalidation
71 : ParentOnlyInvalidation); 71 : ParentOnlyInvalidation);
72 } 72 }
73 73
74 void LayoutSVGResourceFilter::removeClientFromCache(LayoutObject* client, 74 void LayoutSVGResourceFilter::removeClientFromCache(LayoutObject* client,
75 bool markForInvalidation) { 75 bool markForInvalidation) {
76 ASSERT(client); 76 DCHECK(client);
77 77
78 bool filterCached = m_filter.contains(client); 78 bool filterCached = m_filter.contains(client);
79 if (filterCached) 79 if (filterCached)
80 m_filter.erase(client); 80 m_filter.erase(client);
81 81
82 // If the filter has a cached subtree, invalidate the associated display item. 82 // If the filter has a cached subtree, invalidate the associated display item.
83 if (markForInvalidation && filterCached) 83 if (markForInvalidation && filterCached)
84 markClientForInvalidation(client, PaintInvalidation); 84 markClientForInvalidation(client, PaintInvalidation);
85 85
86 markClientForInvalidation(client, markForInvalidation 86 markClientForInvalidation(client, markForInvalidation
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 return; 133 return;
134 nodeMap->invalidateDependentEffects(effect); 134 nodeMap->invalidateDependentEffects(effect);
135 135
136 // Issue paint invalidations for the image on the screen. 136 // Issue paint invalidations for the image on the screen.
137 markClientForInvalidation(filter.key, PaintInvalidation); 137 markClientForInvalidation(filter.key, PaintInvalidation);
138 } 138 }
139 notifyContentChanged(); 139 notifyContentChanged();
140 } 140 }
141 141
142 } // namespace blink 142 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698