third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp - Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs> (Closed)

Patch Set: Rebase with latest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

index 9cd0ef208a15a8aa01a3b9f5effd352df7e97190..45253ee0d115ae055bc2285911a6db06d7b202bd 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

@@ -43,7 +43,7 @@ LayoutSVGContainer::LayoutSVGContainer(SVGElement* node)

LayoutSVGContainer::~LayoutSVGContainer() {}

void LayoutSVGContainer::layout() {

- ASSERT(needsLayout());

+ DCHECK(needsLayout());

LayoutAnalyzer::Scope analyzer(*this);

// Update the local transform in subclasses.

@@ -73,7 +73,7 @@ void LayoutSVGContainer::layout() {

LayoutSVGModelObject::setNeedsBoundariesUpdate();

}

- ASSERT(!m_needsBoundariesUpdate);

+ DCHECK(!m_needsBoundariesUpdate);

clearNeedsLayout();

}