Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp

Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs> (Closed)
Patch Set: Rebase with latest Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp
index 01d958f57372f611fbdb7722ffc231e2c5d6327f..fc5534e29b2ba9dced3bc4e07b8ee72dba66b62b 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp
@@ -49,7 +49,7 @@ LayoutSVGRoot::LayoutSVGRoot(SVGElement* node)
m_hasNonIsolatedBlendingDescendants(false),
m_hasNonIsolatedBlendingDescendantsDirty(false) {
SVGSVGElement* svg = toSVGSVGElement(node);
- ASSERT(svg);
+ DCHECK(svg);
LayoutSize intrinsicSize(svg->intrinsicWidth(), svg->intrinsicHeight());
if (!svg->hasIntrinsicWidth())
@@ -66,7 +66,7 @@ void LayoutSVGRoot::computeIntrinsicSizingInfo(
// https://www.w3.org/TR/SVG/coords.html#IntrinsicSizing
SVGSVGElement* svg = toSVGSVGElement(node());
- ASSERT(svg);
+ DCHECK(svg);
intrinsicSizingInfo.size =
FloatSize(svg->intrinsicWidth(), svg->intrinsicHeight());
@@ -138,7 +138,7 @@ LayoutUnit LayoutSVGRoot::computeReplacedLogicalHeight(
}
void LayoutSVGRoot::layout() {
- ASSERT(needsLayout());
+ DCHECK(needsLayout());
LayoutAnalyzer::Scope analyzer(*this);
LayoutSize oldSize = size();
@@ -179,7 +179,7 @@ void LayoutSVGRoot::layout() {
}
SVGSVGElement* svg = toSVGSVGElement(node());
- ASSERT(svg);
+ DCHECK(svg);
// When hasRelativeLengths() is false, no descendants have relative lengths
// (hence no one is interested in viewport size changes).
m_isLayoutSizeChanged = viewportMayHaveChanged && svg->hasRelativeLengths();
@@ -350,7 +350,7 @@ PositionWithAffinity LayoutSVGRoot::positionForPoint(const LayoutPoint& point) {
SVGTransformChange LayoutSVGRoot::buildLocalToBorderBoxTransform() {
SVGTransformChangeDetector changeDetector(m_localToBorderBoxTransform);
SVGSVGElement* svg = toSVGSVGElement(node());
- ASSERT(svg);
+ DCHECK(svg);
float scale = style()->effectiveZoom();
m_localToBorderBoxTransform = svg->viewBoxToViewTransform(
contentWidth() / scale, contentHeight() / scale);

Powered by Google App Engine
This is Rietveld 408576698