Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp

Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs> (Closed)
Patch Set: Rebase with latest Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp
index cb8752dfb0119036930112ff8c25291632843d67..676a489636b30f81a451be0aa18bee91d06956a5 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp
@@ -109,7 +109,7 @@ FloatRect LayoutSVGShape::hitTestStrokeBoundingBox() const {
}
bool LayoutSVGShape::shapeDependentStrokeContains(const FloatPoint& point) {
- ASSERT(m_path);
+ DCHECK(m_path);
StrokeData strokeData;
SVGLayoutSupport::applyStrokeStyleToStrokeData(strokeData, styleRef(), *this,
dashScaleFactor());
@@ -206,9 +206,9 @@ void LayoutSVGShape::layout() {
if (updateParentBoundaries)
LayoutSVGModelObject::setNeedsBoundariesUpdate();
- ASSERT(!m_needsShapeUpdate);
- ASSERT(!m_needsBoundariesUpdate);
- ASSERT(!m_needsTransformUpdate);
+ DCHECK(!m_needsShapeUpdate);
+ DCHECK(!m_needsBoundariesUpdate);
+ DCHECK(!m_needsTransformUpdate);
clearNeedsLayout();
}
@@ -301,7 +301,7 @@ FloatRect LayoutSVGShape::calculateObjectBoundingBox() const {
}
FloatRect LayoutSVGShape::calculateStrokeBoundingBox() const {
- ASSERT(m_path);
+ DCHECK(m_path);
FloatRect strokeBoundingBox = m_fillBoundingBox;
if (style()->svgStyle().hasStroke()) {

Powered by Google App Engine
This is Rietveld 408576698