Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp

Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs> (Closed)
Patch Set: Rebase with latest Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp
index cf36a430aa6198a3035699bd6d8320e0787262d6..73c03b45f2c47d8e6a39a34ac9b486aefa181cd8 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp
@@ -46,7 +46,7 @@ void LayoutSVGResourceContainer::layout() {
// FIXME: Investigate a way to detect and break resource layout dependency
// cycles early. Then we can remove this method altogether, and fall back onto
// LayoutSVGHiddenContainer::layout().
- ASSERT(needsLayout());
+ DCHECK(needsLayout());
if (m_isInLayout)
return;
@@ -146,8 +146,8 @@ void LayoutSVGResourceContainer::markAllClientsForInvalidation(
void LayoutSVGResourceContainer::markClientForInvalidation(
LayoutObject* client,
InvalidationMode mode) {
- ASSERT(client);
- ASSERT(!m_clients.isEmpty());
+ DCHECK(client);
+ DCHECK(!m_clients.isEmpty());
switch (mode) {
case LayoutAndBoundariesInvalidation:
@@ -171,13 +171,13 @@ void LayoutSVGResourceContainer::markClientForInvalidation(
}
void LayoutSVGResourceContainer::addClient(LayoutObject* client) {
- ASSERT(client);
+ DCHECK(client);
m_clients.insert(client);
clearInvalidationMask();
}
void LayoutSVGResourceContainer::removeClient(LayoutObject* client) {
- ASSERT(client);
+ DCHECK(client);
removeClientFromCache(client, false);
m_clients.erase(client);
}
@@ -198,7 +198,7 @@ void LayoutSVGResourceContainer::invalidateCacheAndMarkForLayout(
static inline void removeFromCacheAndInvalidateDependencies(
LayoutObject* object,
bool needsLayout) {
- ASSERT(object);
+ DCHECK(object);
if (SVGResources* resources =
SVGResourcesCache::cachedResourcesForLayoutObject(object)) {
resources->removeClientFromCacheAffectingObjectBounds(object);
@@ -237,8 +237,8 @@ static inline void removeFromCacheAndInvalidateDependencies(
void LayoutSVGResourceContainer::markForLayoutAndParentResourceInvalidation(
LayoutObject* object,
bool needsLayout) {
- ASSERT(object);
- ASSERT(object->node());
+ DCHECK(object);
+ DCHECK(object->node());
if (needsLayout && !object->documentBeingDestroyed())
object->setNeedsLayoutAndFullPaintInvalidation(

Powered by Google App Engine
This is Rietveld 408576698