Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: third_party/WebKit/Source/core/layout/shapes/ShapeInterval.h

Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs> (Closed)
Patch Set: Rebase with latest Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/shapes/ShapeInterval.h
diff --git a/third_party/WebKit/Source/core/layout/shapes/ShapeInterval.h b/third_party/WebKit/Source/core/layout/shapes/ShapeInterval.h
index 400b825f9a2022d84454fbf33ad38c6601935cfa..b55f2e672c0ece78d0019d753b49c45ca261b92e 100644
--- a/third_party/WebKit/Source/core/layout/shapes/ShapeInterval.h
+++ b/third_party/WebKit/Source/core/layout/shapes/ShapeInterval.h
@@ -42,10 +42,10 @@ class ShapeInterval {
ShapeInterval() : m_x1(-1), m_x2(-2) {
// The initial values of m_x1,x2 don't matter (unless you're looking
// at them in the debugger) so long as isUndefined() is true.
- ASSERT(isUndefined());
+ DCHECK(isUndefined());
}
- ShapeInterval(T x1, T x2) : m_x1(x1), m_x2(x2) { ASSERT(x2 >= x1); }
+ ShapeInterval(T x1, T x2) : m_x1(x1), m_x2(x2) { DCHECK(x2 >= x1); }
bool isUndefined() const { return m_x2 < m_x1; }
T x1() const { return isUndefined() ? 0 : m_x1; }
@@ -54,7 +54,7 @@ class ShapeInterval {
bool isEmpty() const { return isUndefined() ? true : m_x1 == m_x2; }
void set(T x1, T x2) {
- ASSERT(x2 >= x1);
+ DCHECK_GE(x2, x1);
m_x1 = x1;
m_x2 = x2;
}

Powered by Google App Engine
This is Rietveld 408576698