Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 2372713005: Revert of Unify rtcp packet setters (Closed)

Created:
4 years, 2 months ago by kjellander_webrtc
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Unify rtcp packet setters (patchset #8 id:130001 of https://codereview.webrtc.org/2348623003/ ) Reason for revert: Breaks compilation of internal downstream project. Original issue's description: > Unify rtcp packet setters > Renamed setters in rtcp classes > from WithField to SetField > from WithItem to AddItem or SetItems > from From to SetSenderSsrc > from To to SetMediaSsrc > Some redundant or unsued setters removed. > Pass-by-const& replaced with pass-by-value when appropriate. > > BUG=webrtc:5260 > > Committed: https://crrev.com/20e77c7b8a9f19942ef3c3c4f1fa3888b2cd54ea > Cr-Commit-Position: refs/heads/master@{#14393} TBR=sprang@webrtc.org,stefan@webrtc.org,danilchap@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5260 Committed: https://crrev.com/efc6e41866662e0922858fbce1d9ee3bdd0637ed Cr-Commit-Position: refs/heads/master@{#14400}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+689 lines, -674 lines) Patch
M webrtc/call/rtc_event_log_unittest.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M webrtc/modules/pacing/packet_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter_unittest.cc View 6 chunks +27 lines, -27 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet.h View 1 chunk +6 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/app.h View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/app_unittest.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/bye_unittest.cc View 7 chunks +20 lines, -16 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/compound_packet_unittest.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h View 3 chunks +3 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report_unittest.cc View 1 chunk +12 lines, -10 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.h View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports_unittest.cc View 11 chunks +41 lines, -41 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/fir_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/nack.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/nack.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/nack_unittest.cc View 5 chunks +15 lines, -15 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/pli_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/psfb.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/rapid_resync_request_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report_unittest.cc View 4 chunks +20 lines, -20 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.h View 3 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.cc View 2 chunks +13 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc View 4 chunks +28 lines, -11 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/report_block.h View 1 chunk +7 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/report_block.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/report_block_unittest.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi_unittest.cc View 9 chunks +17 lines, -17 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/rrtr.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/rrtr_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes_unittest.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.h View 1 chunk +6 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report_unittest.cc View 4 chunks +18 lines, -18 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/sli.h View 1 chunk +5 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/sli_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h View 2 chunks +5 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h View 3 chunks +9 lines, -22 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback_unittest.cc View 6 chunks +32 lines, -32 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/voip_metric.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/voip_metric_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 50 chunks +172 lines, -172 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 17 chunks +59 lines, -57 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kjellander_webrtc
Created Revert of Unify rtcp packet setters
4 years, 2 months ago (2016-09-27 15:39:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2372713005/1
4 years, 2 months ago (2016-09-27 15:39:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 15:39:38 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/efc6e41866662e0922858fbce1d9ee3bdd0637ed Cr-Commit-Position: refs/heads/master@{#14400}
4 years, 2 months ago (2016-09-27 15:39:48 UTC) #6
danilchap
4 years, 2 months ago (2016-09-27 15:51:10 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2370313002/ by danilchap@webrtc.org.

The reason for reverting is: Fix backward compatibility support.

Powered by Google App Engine
This is Rietveld 408576698