Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/nack_unittest.cc

Issue 2372713005: Revert of Unify rtcp packet setters (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/nack_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/nack_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/nack_unittest.cc
index a9920196c404df6db55ae6f4b227968bcfbdeb9b..d335d66bf89fd596394206f3e20a686a87405a9f 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/nack_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/nack_unittest.cc
@@ -57,9 +57,9 @@
TEST(RtcpPacketNackTest, Create) {
Nack nack;
- nack.SetSenderSsrc(kSenderSsrc);
- nack.SetMediaSsrc(kRemoteSsrc);
- nack.SetPacketIds(kList, kListLength);
+ nack.From(kSenderSsrc);
+ nack.To(kRemoteSsrc);
+ nack.WithList(kList, kListLength);
rtc::Buffer packet = nack.Build();
@@ -79,9 +79,9 @@
TEST(RtcpPacketNackTest, CreateWrap) {
Nack nack;
- nack.SetSenderSsrc(kSenderSsrc);
- nack.SetMediaSsrc(kRemoteSsrc);
- nack.SetPacketIds(kWrapList, kWrapListLength);
+ nack.From(kSenderSsrc);
+ nack.To(kRemoteSsrc);
+ nack.WithList(kWrapList, kWrapListLength);
rtc::Buffer packet = nack.Build();
@@ -104,9 +104,9 @@
const size_t kUnorderedListLength =
sizeof(kUnorderedList) / sizeof(kUnorderedList[0]);
Nack nack;
- nack.SetSenderSsrc(kSenderSsrc);
- nack.SetMediaSsrc(kRemoteSsrc);
- nack.SetPacketIds(kUnorderedList, kUnorderedListLength);
+ nack.From(kSenderSsrc);
+ nack.To(kRemoteSsrc);
+ nack.WithList(kUnorderedList, kUnorderedListLength);
rtc::Buffer packet = nack.Build();
@@ -122,9 +122,9 @@
Nack nack;
const uint16_t kList[] = {1, 100, 200, 300, 400};
const uint16_t kListLength = sizeof(kList) / sizeof(kList[0]);
- nack.SetSenderSsrc(kSenderSsrc);
- nack.SetMediaSsrc(kRemoteSsrc);
- nack.SetPacketIds(kList, kListLength);
+ nack.From(kSenderSsrc);
+ nack.To(kRemoteSsrc);
+ nack.WithList(kList, kListLength);
class MockPacketReadyCallback : public rtcp::RtcpPacket::PacketReadyCallback {
public:
@@ -156,9 +156,9 @@
const uint16_t kList[] = {1};
const size_t kMinNackBlockSize = 16;
Nack nack;
- nack.SetSenderSsrc(kSenderSsrc);
- nack.SetMediaSsrc(kRemoteSsrc);
- nack.SetPacketIds(kList, 1);
+ nack.From(kSenderSsrc);
+ nack.To(kRemoteSsrc);
+ nack.WithList(kList, 1);
class Verifier : public rtcp::RtcpPacket::PacketReadyCallback {
public:
void OnPacketReady(uint8_t* data, size_t length) override {
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/nack.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/pli_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698