webrtc/modules/rtp_rtcp/source/rtcp_packet/nack.cc - Issue 2372713005: Revert of Unify rtcp packet setters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/nack.cc

Issue 2372713005: Revert of Unify rtcp packet setters (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/nack.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/nack.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/nack.cc

index 956b16f784ad75108c051a191a28e8740c234afe..0c1f577f7b7ba062578af9dcd1d57a5f3f3e41f5 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/nack.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/nack.cc

@@ -121,7 +121,7 @@

packed_.size() * kNackItemLength;

}

-void Nack::SetPacketIds(const uint16_t* nack_list, size_t length) {

+void Nack::WithList(const uint16_t* nack_list, size_t length) {

RTC_DCHECK(nack_list);

RTC_DCHECK(packet_ids_.empty());

RTC_DCHECK(packed_.empty());