Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.h

Issue 2372713005: Revert of Unify rtcp packet setters (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.h
index c1db9e8d4d321084a5bf75e87691246ad3359373..ad28cb39e7b83de5dece52a64493cff0764cf868 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.h
@@ -32,9 +32,9 @@
// Parse assumes header is already parsed and validated.
bool Parse(const CommonHeader& packet);
- void SetSenderSsrc(uint32_t ssrc) { sender_ssrc_ = ssrc; }
- bool SetCsrcs(std::vector<uint32_t> csrcs);
- void SetReason(std::string reason);
+ void From(uint32_t ssrc) { sender_ssrc_ = ssrc; }
+ bool WithCsrc(uint32_t csrc);
+ void WithReason(const std::string& reason);
uint32_t sender_ssrc() const { return sender_ssrc_; }
const std::vector<uint32_t>& csrcs() const { return csrcs_; }
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/app_unittest.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698