Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.h

Issue 2372713005: Revert of Unify rtcp packet setters (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 * 9 *
10 */ 10 */
(...skipping 14 matching lines...) Expand all
25 class Bye : public RtcpPacket { 25 class Bye : public RtcpPacket {
26 public: 26 public:
27 static const uint8_t kPacketType = 203; 27 static const uint8_t kPacketType = 203;
28 28
29 Bye(); 29 Bye();
30 ~Bye() override {} 30 ~Bye() override {}
31 31
32 // Parse assumes header is already parsed and validated. 32 // Parse assumes header is already parsed and validated.
33 bool Parse(const CommonHeader& packet); 33 bool Parse(const CommonHeader& packet);
34 34
35 void SetSenderSsrc(uint32_t ssrc) { sender_ssrc_ = ssrc; } 35 void From(uint32_t ssrc) { sender_ssrc_ = ssrc; }
36 bool SetCsrcs(std::vector<uint32_t> csrcs); 36 bool WithCsrc(uint32_t csrc);
37 void SetReason(std::string reason); 37 void WithReason(const std::string& reason);
38 38
39 uint32_t sender_ssrc() const { return sender_ssrc_; } 39 uint32_t sender_ssrc() const { return sender_ssrc_; }
40 const std::vector<uint32_t>& csrcs() const { return csrcs_; } 40 const std::vector<uint32_t>& csrcs() const { return csrcs_; }
41 const std::string& reason() const { return reason_; } 41 const std::string& reason() const { return reason_; }
42 42
43 protected: 43 protected:
44 bool Create(uint8_t* packet, 44 bool Create(uint8_t* packet,
45 size_t* index, 45 size_t* index,
46 size_t max_length, 46 size_t max_length,
47 RtcpPacket::PacketReadyCallback* callback) const override; 47 RtcpPacket::PacketReadyCallback* callback) const override;
48 48
49 private: 49 private:
50 static const int kMaxNumberOfCsrcs = 0x1f - 1; // First item is sender SSRC. 50 static const int kMaxNumberOfCsrcs = 0x1f - 1; // First item is sender SSRC.
51 51
52 size_t BlockLength() const override; 52 size_t BlockLength() const override;
53 53
54 uint32_t sender_ssrc_; 54 uint32_t sender_ssrc_;
55 std::vector<uint32_t> csrcs_; 55 std::vector<uint32_t> csrcs_;
56 std::string reason_; 56 std::string reason_;
57 57
58 RTC_DISALLOW_COPY_AND_ASSIGN(Bye); 58 RTC_DISALLOW_COPY_AND_ASSIGN(Bye);
59 }; 59 };
60 60
61 } // namespace rtcp 61 } // namespace rtcp
62 } // namespace webrtc 62 } // namespace webrtc
63 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_BYE_H_ 63 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_BYE_H_
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/app_unittest.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698