Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1556)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h

Issue 2372713005: Revert of Unify rtcp packet setters (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 16 matching lines...) Expand all
27 class Tmmbn : public Rtpfb { 27 class Tmmbn : public Rtpfb {
28 public: 28 public:
29 static constexpr uint8_t kFeedbackMessageType = 4; 29 static constexpr uint8_t kFeedbackMessageType = 4;
30 30
31 Tmmbn() {} 31 Tmmbn() {}
32 ~Tmmbn() override {} 32 ~Tmmbn() override {}
33 33
34 // Parse assumes header is already parsed and validated. 34 // Parse assumes header is already parsed and validated.
35 bool Parse(const CommonHeader& packet); 35 bool Parse(const CommonHeader& packet);
36 36
37 void AddTmmbr(const TmmbItem& item); 37 void WithTmmbr(uint32_t ssrc, uint32_t bitrate_kbps, uint16_t overhead) {
38 WithTmmbr(TmmbItem(ssrc, bitrate_kbps * 1000, overhead));
39 }
40 void WithTmmbr(const TmmbItem& item);
38 41
39 const std::vector<TmmbItem>& items() const { return items_; } 42 const std::vector<TmmbItem>& items() const { return items_; }
40 43
41 protected: 44 protected:
42 bool Create(uint8_t* packet, 45 bool Create(uint8_t* packet,
43 size_t* index, 46 size_t* index,
44 size_t max_length, 47 size_t max_length,
45 RtcpPacket::PacketReadyCallback* callback) const override; 48 RtcpPacket::PacketReadyCallback* callback) const override;
46 49
47 private: 50 private:
48 size_t BlockLength() const override { 51 size_t BlockLength() const override {
49 return kHeaderLength + kCommonFeedbackLength + 52 return kHeaderLength + kCommonFeedbackLength +
50 TmmbItem::kLength * items_.size(); 53 TmmbItem::kLength * items_.size();
51 } 54 }
52 55
53 // Media ssrc is unused, shadow base class setter and getter. 56 // Media ssrc is unused, shadow base class setter and getter.
54 void SetMediaSsrc(uint32_t ssrc); 57 void To(uint32_t ssrc);
55 uint32_t media_ssrc() const; 58 uint32_t media_ssrc() const;
56 59
57 std::vector<TmmbItem> items_; 60 std::vector<TmmbItem> items_;
58 61
59 RTC_DISALLOW_COPY_AND_ASSIGN(Tmmbn); 62 RTC_DISALLOW_COPY_AND_ASSIGN(Tmmbn);
60 }; 63 };
61 } // namespace rtcp 64 } // namespace rtcp
62 } // namespace webrtc 65 } // namespace webrtc
63 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_TMMBN_H_ 66 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_TMMBN_H_
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/sli_unittest.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698