Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr_unittest.cc

Issue 2372713005: Revert of Unify rtcp packet setters (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 17 matching lines...) Expand all
28 const uint16_t kOverhead = 0x1fe; 28 const uint16_t kOverhead = 0x1fe;
29 const uint8_t kPacket[] = {0x83, 205, 0x00, 0x04, 29 const uint8_t kPacket[] = {0x83, 205, 0x00, 0x04,
30 0x12, 0x34, 0x56, 0x78, 30 0x12, 0x34, 0x56, 0x78,
31 0x00, 0x00, 0x00, 0x00, 31 0x00, 0x00, 0x00, 0x00,
32 0x23, 0x45, 0x67, 0x89, 32 0x23, 0x45, 0x67, 0x89,
33 0x0a, 0x61, 0x61, 0xfe}; 33 0x0a, 0x61, 0x61, 0xfe};
34 } // namespace 34 } // namespace
35 35
36 TEST(RtcpPacketTmmbrTest, Create) { 36 TEST(RtcpPacketTmmbrTest, Create) {
37 Tmmbr tmmbr; 37 Tmmbr tmmbr;
38 tmmbr.SetSenderSsrc(kSenderSsrc); 38 tmmbr.From(kSenderSsrc);
39 tmmbr.AddTmmbr(TmmbItem(kRemoteSsrc, kBitrateBps, kOverhead)); 39 tmmbr.WithTmmbr(TmmbItem(kRemoteSsrc, kBitrateBps, kOverhead));
40 40
41 rtc::Buffer packet = tmmbr.Build(); 41 rtc::Buffer packet = tmmbr.Build();
42 42
43 EXPECT_THAT(make_tuple(packet.data(), packet.size()), 43 EXPECT_THAT(make_tuple(packet.data(), packet.size()),
44 ElementsAreArray(kPacket)); 44 ElementsAreArray(kPacket));
45 } 45 }
46 46
47 TEST(RtcpPacketTmmbrTest, Parse) { 47 TEST(RtcpPacketTmmbrTest, Parse) {
48 Tmmbr tmmbr; 48 Tmmbr tmmbr;
49 EXPECT_TRUE(test::ParseSinglePacket(kPacket, &tmmbr)); 49 EXPECT_TRUE(test::ParseSinglePacket(kPacket, &tmmbr));
50 const Tmmbr& parsed = tmmbr; 50 const Tmmbr& parsed = tmmbr;
51 51
52 EXPECT_EQ(kSenderSsrc, parsed.sender_ssrc()); 52 EXPECT_EQ(kSenderSsrc, parsed.sender_ssrc());
53 ASSERT_EQ(1u, parsed.requests().size()); 53 ASSERT_EQ(1u, parsed.requests().size());
54 EXPECT_EQ(kRemoteSsrc, parsed.requests().front().ssrc()); 54 EXPECT_EQ(kRemoteSsrc, parsed.requests().front().ssrc());
55 EXPECT_EQ(kBitrateBps, parsed.requests().front().bitrate_bps()); 55 EXPECT_EQ(kBitrateBps, parsed.requests().front().bitrate_bps());
56 EXPECT_EQ(kOverhead, parsed.requests().front().packet_overhead()); 56 EXPECT_EQ(kOverhead, parsed.requests().front().packet_overhead());
57 } 57 }
58 58
59 TEST(RtcpPacketTmmbrTest, CreateAndParseWithTwoEntries) { 59 TEST(RtcpPacketTmmbrTest, CreateAndParseWithTwoEntries) {
60 Tmmbr tmmbr; 60 Tmmbr tmmbr;
61 tmmbr.SetSenderSsrc(kSenderSsrc); 61 tmmbr.From(kSenderSsrc);
62 tmmbr.AddTmmbr(TmmbItem(kRemoteSsrc, kBitrateBps, kOverhead)); 62 tmmbr.WithTmmbr(TmmbItem(kRemoteSsrc, kBitrateBps, kOverhead));
63 tmmbr.AddTmmbr(TmmbItem(kRemoteSsrc + 1, 4 * kBitrateBps, kOverhead + 1)); 63 tmmbr.WithTmmbr(TmmbItem(kRemoteSsrc + 1, 4 * kBitrateBps, kOverhead + 1));
64 64
65 rtc::Buffer packet = tmmbr.Build(); 65 rtc::Buffer packet = tmmbr.Build();
66 66
67 Tmmbr parsed; 67 Tmmbr parsed;
68 EXPECT_TRUE(test::ParseSinglePacket(packet, &parsed)); 68 EXPECT_TRUE(test::ParseSinglePacket(packet, &parsed));
69 69
70 EXPECT_EQ(kSenderSsrc, parsed.sender_ssrc()); 70 EXPECT_EQ(kSenderSsrc, parsed.sender_ssrc());
71 EXPECT_EQ(2u, parsed.requests().size()); 71 EXPECT_EQ(2u, parsed.requests().size());
72 EXPECT_EQ(kRemoteSsrc, parsed.requests()[0].ssrc()); 72 EXPECT_EQ(kRemoteSsrc, parsed.requests()[0].ssrc());
73 EXPECT_EQ(kRemoteSsrc + 1, parsed.requests()[1].ssrc()); 73 EXPECT_EQ(kRemoteSsrc + 1, parsed.requests()[1].ssrc());
(...skipping 13 matching lines...) Expand all
87 0x12, 0x34, 0x56, 0x78, 87 0x12, 0x34, 0x56, 0x78,
88 0x00, 0x00, 0x00, 0x00, 88 0x00, 0x00, 0x00, 0x00,
89 0x23, 0x45, 0x67, 0x89, 89 0x23, 0x45, 0x67, 0x89,
90 0x0a, 0x61, 0x61, 0xfe, 90 0x0a, 0x61, 0x61, 0xfe,
91 0x34, 0x56, 0x78, 0x9a}; 91 0x34, 0x56, 0x78, 0x9a};
92 92
93 Tmmbr tmmbr; 93 Tmmbr tmmbr;
94 EXPECT_FALSE(test::ParseSinglePacket(kUnalignedPacket, &tmmbr)); 94 EXPECT_FALSE(test::ParseSinglePacket(kUnalignedPacket, &tmmbr));
95 } 95 }
96 } // namespace webrtc 96 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698