Revert of Unify rtcp packet setters

webrtc/modules/rtp_rtcp/source/rtcp_packet/app.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 33 matching lines @@
     return false;
   }
   sub_type_ = packet.fmt();
   ssrc_ = ByteReader<uint32_t>::ReadBigEndian(&packet.payload()[0]);
   name_ = ByteReader<uint32_t>::ReadBigEndian(&packet.payload()[4]);
   data_.SetData(packet.payload() + kAppBaseLength,
                 packet.payload_size_bytes() - kAppBaseLength);
   return true;
 }
 
-void App::SetSubType(uint8_t subtype) {
+void App::WithSubType(uint8_t subtype) {
   RTC_DCHECK_LE(subtype, 0x1f);
   sub_type_ = subtype;
 }
 
-void App::SetData(const uint8_t* data, size_t data_length) {
+void App::WithData(const uint8_t* data, size_t data_length) {
   RTC_DCHECK(data);
   RTC_DCHECK_EQ(data_length % 4, 0u) << "Data must be 32 bits aligned.";
   RTC_DCHECK_LE(data_length, kMaxDataSize) << "App data size " << data_length
                                            << " exceed maximum of "
                                            << kMaxDataSize << " bytes.";
   data_.SetData(data, data_length);
 }
 
 bool App::Create(uint8_t* packet,
                  size_t* index,
                  size_t max_length,
                  RtcpPacket::PacketReadyCallback* callback) const {
   while (*index + BlockLength() > max_length) {
     if (!OnBufferFull(packet, index, callback))
       return false;
   }
   const size_t index_end = *index + BlockLength();
   CreateHeader(sub_type_, kPacketType, HeaderLength(), packet, index);
 
   ByteWriter<uint32_t>::WriteBigEndian(&packet[*index + 0], ssrc_);
   ByteWriter<uint32_t>::WriteBigEndian(&packet[*index + 4], name_);
   memcpy(&packet[*index + 8], data_.data(), data_.size());
   *index += (8 + data_.size());
   RTC_DCHECK_EQ(index_end, *index);
   return true;
 }
 
 }  // namespace rtcp
 }  // namespace webrtc