Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi.h

Issue 2372713005: Revert of Unify rtcp packet setters (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 12 matching lines...) Expand all
23 // Assumes native bit string stores PictureId (VP8, VP9). 23 // Assumes native bit string stores PictureId (VP8, VP9).
24 class Rpsi : public Psfb { 24 class Rpsi : public Psfb {
25 public: 25 public:
26 static constexpr uint8_t kFeedbackMessageType = 3; 26 static constexpr uint8_t kFeedbackMessageType = 3;
27 Rpsi(); 27 Rpsi();
28 ~Rpsi() override {} 28 ~Rpsi() override {}
29 29
30 // Parse assumes header is already parsed and validated. 30 // Parse assumes header is already parsed and validated.
31 bool Parse(const CommonHeader& packet); 31 bool Parse(const CommonHeader& packet);
32 32
33 void SetPayloadType(uint8_t payload); 33 void WithPayloadType(uint8_t payload);
34 void SetPictureId(uint64_t picture_id); 34 void WithPictureId(uint64_t picture_id);
35 35
36 uint8_t payload_type() const { return payload_type_; } 36 uint8_t payload_type() const { return payload_type_; }
37 uint64_t picture_id() const { return picture_id_; } 37 uint64_t picture_id() const { return picture_id_; }
38 38
39 protected: 39 protected:
40 bool Create(uint8_t* packet, 40 bool Create(uint8_t* packet,
41 size_t* index, 41 size_t* index,
42 size_t max_length, 42 size_t max_length,
43 RtcpPacket::PacketReadyCallback* callback) const override; 43 RtcpPacket::PacketReadyCallback* callback) const override;
44 44
45 private: 45 private:
46 size_t BlockLength() const override { return block_length_; } 46 size_t BlockLength() const override { return block_length_; }
47 static size_t CalculateBlockLength(uint8_t bitstring_size_bytes); 47 static size_t CalculateBlockLength(uint8_t bitstring_size_bytes);
48 48
49 uint8_t payload_type_; 49 uint8_t payload_type_;
50 uint64_t picture_id_; 50 uint64_t picture_id_;
51 size_t block_length_; 51 size_t block_length_;
52 52
53 RTC_DISALLOW_COPY_AND_ASSIGN(Rpsi); 53 RTC_DISALLOW_COPY_AND_ASSIGN(Rpsi);
54 }; 54 };
55 } // namespace rtcp 55 } // namespace rtcp
56 } // namespace webrtc 56 } // namespace webrtc
57 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_RPSI_H_ 57 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_RPSI_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698