webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.h - Issue 2372713005: Revert of Unify rtcp packet setters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.h

Issue 2372713005: Revert of Unify rtcp packet setters (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.h

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.h

index c2a4b8fffcc6cdeda1650aaeb868a6ad4e3de53a..a48c3394ae1fba044edccf01c17c28a922e41145 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.h

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.h

@@ -50,8 +50,8 @@

void Create(uint8_t* buffer) const;

// Max 100 DLRR Items can be added per DLRR report block.

- bool AddDlrrItem(const ReceiveTimeInfo& time_info);

- bool AddDlrrItem(uint32_t ssrc, uint32_t last_rr, uint32_t delay_last_rr);

+ bool WithDlrrItem(const ReceiveTimeInfo& time_info);

+ bool WithDlrrItem(uint32_t ssrc, uint32_t last_rr, uint32_t delay_last_rr);

const std::vector<ReceiveTimeInfo>& sub_blocks() const { return sub_blocks_; }