Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h

Issue 2372713005: Revert of Unify rtcp packet setters (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h
index b26dc46b2c53ebc8cc577a2821aa2a863d432851..7731988df47f151c0fc73ba3333ed4227659d6c2 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h
@@ -23,7 +23,6 @@
class ExtendedJitterReport : public RtcpPacket {
public:
static constexpr uint8_t kPacketType = 195;
- static constexpr size_t kMaxNumberOfJitterValues = 0x1f;
ExtendedJitterReport() {}
~ExtendedJitterReport() override {}
@@ -31,11 +30,9 @@
// Parse assumes header is already parsed and validated.
bool Parse(const CommonHeader& packet);
- bool SetJitterValues(std::vector<uint32_t> jitter_values);
+ bool WithJitter(uint32_t jitter);
- const std::vector<uint32_t>& jitter_values() {
- return inter_arrival_jitters_;
- }
+ const std::vector<uint32_t>& jitters() { return inter_arrival_jitters_; }
protected:
bool Create(uint8_t* packet,
@@ -44,6 +41,7 @@
RtcpPacket::PacketReadyCallback* callback) const override;
private:
+ static constexpr size_t kMaxNumberOfJitters = 0x1f;
static constexpr size_t kJitterSizeBytes = 4;
size_t BlockLength() const override {

Powered by Google App Engine
This is Rietveld 408576698