Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h

Issue 2372713005: Revert of Unify rtcp packet setters (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_EXTENDED_JITTER_REPORT_H_ 11 #ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_EXTENDED_JITTER_REPORT_H_
12 #define WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_EXTENDED_JITTER_REPORT_H_ 12 #define WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_EXTENDED_JITTER_REPORT_H_
13 13
14 #include <vector> 14 #include <vector>
15 15
16 #include "webrtc/base/constructormagic.h" 16 #include "webrtc/base/constructormagic.h"
17 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet.h" 17 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet.h"
18 18
19 namespace webrtc { 19 namespace webrtc {
20 namespace rtcp { 20 namespace rtcp {
21 class CommonHeader; 21 class CommonHeader;
22 22
23 class ExtendedJitterReport : public RtcpPacket { 23 class ExtendedJitterReport : public RtcpPacket {
24 public: 24 public:
25 static constexpr uint8_t kPacketType = 195; 25 static constexpr uint8_t kPacketType = 195;
26 static constexpr size_t kMaxNumberOfJitterValues = 0x1f;
27 26
28 ExtendedJitterReport() {} 27 ExtendedJitterReport() {}
29 ~ExtendedJitterReport() override {} 28 ~ExtendedJitterReport() override {}
30 29
31 // Parse assumes header is already parsed and validated. 30 // Parse assumes header is already parsed and validated.
32 bool Parse(const CommonHeader& packet); 31 bool Parse(const CommonHeader& packet);
33 32
34 bool SetJitterValues(std::vector<uint32_t> jitter_values); 33 bool WithJitter(uint32_t jitter);
35 34
36 const std::vector<uint32_t>& jitter_values() { 35 const std::vector<uint32_t>& jitters() { return inter_arrival_jitters_; }
37 return inter_arrival_jitters_;
38 }
39 36
40 protected: 37 protected:
41 bool Create(uint8_t* packet, 38 bool Create(uint8_t* packet,
42 size_t* index, 39 size_t* index,
43 size_t max_length, 40 size_t max_length,
44 RtcpPacket::PacketReadyCallback* callback) const override; 41 RtcpPacket::PacketReadyCallback* callback) const override;
45 42
46 private: 43 private:
44 static constexpr size_t kMaxNumberOfJitters = 0x1f;
47 static constexpr size_t kJitterSizeBytes = 4; 45 static constexpr size_t kJitterSizeBytes = 4;
48 46
49 size_t BlockLength() const override { 47 size_t BlockLength() const override {
50 return kHeaderLength + kJitterSizeBytes * inter_arrival_jitters_.size(); 48 return kHeaderLength + kJitterSizeBytes * inter_arrival_jitters_.size();
51 } 49 }
52 50
53 std::vector<uint32_t> inter_arrival_jitters_; 51 std::vector<uint32_t> inter_arrival_jitters_;
54 52
55 RTC_DISALLOW_COPY_AND_ASSIGN(ExtendedJitterReport); 53 RTC_DISALLOW_COPY_AND_ASSIGN(ExtendedJitterReport);
56 }; 54 };
57 55
58 } // namespace rtcp 56 } // namespace rtcp
59 } // namespace webrtc 57 } // namespace webrtc
60 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_EXTENDED_JITTER_REPORT_H_ 58 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_EXTENDED_JITTER_REPORT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698