Revert of Unify rtcp packet setters

webrtc/modules/rtp_rtcp/source/rtcp_packet/app_unittest.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 35 matching lines @@
 constexpr uint8_t kPacketWithUnalignedPayload[] = {
     kVersionBits | kPaddingBit | kSubtype, App::kPacketType, 0x00, 0x03,
     0x12, 0x34, 0x56, 0x78,
      'n',  'a',  'm',  'e',
      'd',  'a',  't', kPaddingSize};
 // clang-format on
 }  // namespace
 
 TEST(RtcpPacketAppTest, CreateWithoutData) {
   App app;
-  app.SetSsrc(kSenderSsrc);
-  app.SetSubType(kSubtype);
-  app.SetName(kName);
+  app.From(kSenderSsrc);
+  app.WithSubType(kSubtype);
+  app.WithName(kName);
 
   rtc::Buffer raw = app.Build();
 
   EXPECT_THAT(make_tuple(raw.data(), raw.size()),
               ElementsAreArray(kPacketWithoutData));
 }
 
 TEST(RtcpPacketAppTest, ParseWithoutData) {
   App parsed;
   EXPECT_TRUE(test::ParseSinglePacket(kPacketWithoutData, &parsed));
 
   EXPECT_EQ(kSenderSsrc, parsed.ssrc());
   EXPECT_EQ(kSubtype, parsed.sub_type());
   EXPECT_EQ(kName, parsed.name());
   EXPECT_EQ(0u, parsed.data_size());
 }
 
 TEST(RtcpPacketAppTest, CreateWithData) {
   App app;
-  app.SetSsrc(kSenderSsrc);
-  app.SetSubType(kSubtype);
-  app.SetName(kName);
-  app.SetData(kData, sizeof(kData));
+  app.From(kSenderSsrc);
+  app.WithSubType(kSubtype);
+  app.WithName(kName);
+  app.WithData(kData, sizeof(kData));
 
   rtc::Buffer raw = app.Build();
 
   EXPECT_THAT(make_tuple(raw.data(), raw.size()),
               ElementsAreArray(kPacketWithData));
 }
 
 TEST(RtcpPacketAppTest, ParseWithData) {
   App parsed;
   EXPECT_TRUE(test::ParseSinglePacket(kPacketWithData, &parsed));
 
   EXPECT_EQ(kSenderSsrc, parsed.ssrc());
   EXPECT_EQ(kSubtype, parsed.sub_type());
   EXPECT_EQ(kName, parsed.name());
   EXPECT_THAT(make_tuple(parsed.data(), parsed.data_size()),
               ElementsAreArray(kData));
 }
 
 TEST(RtcpPacketAppTest, ParseFailsOnTooSmallPacket) {
   App parsed;
   EXPECT_FALSE(test::ParseSinglePacket(kTooSmallPacket, &parsed));
 }
 
 TEST(RtcpPacketAppTest, ParseFailsOnUnalignedPayload) {
   App parsed;
   EXPECT_FALSE(test::ParseSinglePacket(kPacketWithUnalignedPayload, &parsed));
 }
 
 }  // namespace webrtc