Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1232)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/sli_unittest.cc

Issue 2372713005: Revert of Unify rtcp packet setters (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 24 matching lines...) Expand all
35 0x12, 0x34, 0x56, 0x78, 35 0x12, 0x34, 0x56, 0x78,
36 0x23, 0x45, 0x67, 0x89, 36 0x23, 0x45, 0x67, 0x89,
37 (kSliItem >> 24) & 0xff, 37 (kSliItem >> 24) & 0xff,
38 (kSliItem >> 16) & 0xff, 38 (kSliItem >> 16) & 0xff,
39 (kSliItem >> 8) & 0xff, 39 (kSliItem >> 8) & 0xff,
40 kSliItem & 0xff}; 40 kSliItem & 0xff};
41 } // namespace 41 } // namespace
42 42
43 TEST(RtcpPacketSliTest, Create) { 43 TEST(RtcpPacketSliTest, Create) {
44 Sli sli; 44 Sli sli;
45 sli.SetSenderSsrc(kSenderSsrc); 45 sli.From(kSenderSsrc);
46 sli.SetMediaSsrc(kRemoteSsrc); 46 sli.To(kRemoteSsrc);
47 sli.AddPictureId(kPictureId, kFirstMb, kNumberOfMb); 47 sli.WithPictureId(kPictureId, kFirstMb, kNumberOfMb);
48 48
49 rtc::Buffer packet = sli.Build(); 49 rtc::Buffer packet = sli.Build();
50 50
51 EXPECT_THAT(make_tuple(packet.data(), packet.size()), 51 EXPECT_THAT(make_tuple(packet.data(), packet.size()),
52 ElementsAreArray(kPacket)); 52 ElementsAreArray(kPacket));
53 } 53 }
54 54
55 TEST(RtcpPacketSliTest, Parse) { 55 TEST(RtcpPacketSliTest, Parse) {
56 Sli mutable_parsed; 56 Sli mutable_parsed;
57 EXPECT_TRUE(test::ParseSinglePacket(kPacket, &mutable_parsed)); 57 EXPECT_TRUE(test::ParseSinglePacket(kPacket, &mutable_parsed));
58 const Sli& parsed = mutable_parsed; // Read values from constant object. 58 const Sli& parsed = mutable_parsed; // Read values from constant object.
59 59
60 EXPECT_EQ(kSenderSsrc, parsed.sender_ssrc()); 60 EXPECT_EQ(kSenderSsrc, parsed.sender_ssrc());
61 EXPECT_EQ(kRemoteSsrc, parsed.media_ssrc()); 61 EXPECT_EQ(kRemoteSsrc, parsed.media_ssrc());
62 EXPECT_EQ(1u, parsed.macroblocks().size()); 62 EXPECT_EQ(1u, parsed.macroblocks().size());
63 EXPECT_EQ(kFirstMb, parsed.macroblocks()[0].first()); 63 EXPECT_EQ(kFirstMb, parsed.macroblocks()[0].first());
64 EXPECT_EQ(kNumberOfMb, parsed.macroblocks()[0].number()); 64 EXPECT_EQ(kNumberOfMb, parsed.macroblocks()[0].number());
65 EXPECT_EQ(kPictureId, parsed.macroblocks()[0].picture_id()); 65 EXPECT_EQ(kPictureId, parsed.macroblocks()[0].picture_id());
66 } 66 }
67 67
68 TEST(RtcpPacketSliTest, ParseFailsOnTooSmallPacket) { 68 TEST(RtcpPacketSliTest, ParseFailsOnTooSmallPacket) {
69 Sli sli; 69 Sli sli;
70 sli.SetSenderSsrc(kSenderSsrc); 70 sli.From(kSenderSsrc);
71 sli.SetMediaSsrc(kRemoteSsrc); 71 sli.To(kRemoteSsrc);
72 sli.AddPictureId(kPictureId, kFirstMb, kNumberOfMb); 72 sli.WithPictureId(kPictureId, kFirstMb, kNumberOfMb);
73 73
74 rtc::Buffer packet = sli.Build(); 74 rtc::Buffer packet = sli.Build();
75 packet[3]--; // Decrease size by 1 word (4 bytes). 75 packet[3]--; // Decrease size by 1 word (4 bytes).
76 packet.SetSize(packet.size() - 4); 76 packet.SetSize(packet.size() - 4);
77 77
78 EXPECT_FALSE(test::ParseSinglePacket(packet, &sli)); 78 EXPECT_FALSE(test::ParseSinglePacket(packet, &sli));
79 } 79 }
80 80
81 } // namespace webrtc 81 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/sli.h ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698