Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes.h

Issue 2372713005: Revert of Unify rtcp packet setters (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 18 matching lines...) Expand all
29 std::string cname; 29 std::string cname;
30 }; 30 };
31 static const uint8_t kPacketType = 202; 31 static const uint8_t kPacketType = 202;
32 32
33 Sdes(); 33 Sdes();
34 ~Sdes() override; 34 ~Sdes() override;
35 35
36 // Parse assumes header is already parsed and validated. 36 // Parse assumes header is already parsed and validated.
37 bool Parse(const CommonHeader& packet); 37 bool Parse(const CommonHeader& packet);
38 38
39 bool AddCName(uint32_t ssrc, std::string cname); 39 bool WithCName(uint32_t ssrc, const std::string& cname);
40 40
41 const std::vector<Chunk>& chunks() const { return chunks_; } 41 const std::vector<Chunk>& chunks() const { return chunks_; }
42 42
43 size_t BlockLength() const override { return block_length_; } 43 size_t BlockLength() const override { return block_length_; }
44 44
45 protected: 45 protected:
46 bool Create(uint8_t* packet, 46 bool Create(uint8_t* packet,
47 size_t* index, 47 size_t* index,
48 size_t max_length, 48 size_t max_length,
49 RtcpPacket::PacketReadyCallback* callback) const override; 49 RtcpPacket::PacketReadyCallback* callback) const override;
50 50
51 private: 51 private:
52 static const size_t kMaxNumberOfChunks = 0x1f; 52 static const size_t kMaxNumberOfChunks = 0x1f;
53 53
54 std::vector<Chunk> chunks_; 54 std::vector<Chunk> chunks_;
55 size_t block_length_; 55 size_t block_length_;
56 56
57 RTC_DISALLOW_COPY_AND_ASSIGN(Sdes); 57 RTC_DISALLOW_COPY_AND_ASSIGN(Sdes);
58 }; 58 };
59 } // namespace rtcp 59 } // namespace rtcp
60 } // namespace webrtc 60 } // namespace webrtc
61 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_SDES_H_ 61 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_SDES_H_
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.h ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698