webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc - Issue 2372713005: Revert of Unify rtcp packet setters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc

Issue 2372713005: Revert of Unify rtcp packet setters (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc

index 082d1c7773be9646c25c1f7df5e1884da23bad3f..58218ddbfd1a1e3b7df960cefb718ada758d30ce 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc

@@ -24,8 +24,8 @@

TEST(RtcpPacketTest, BuildWithTooSmallBuffer) {

ReportBlock rb;

ReceiverReport rr;

- rr.SetSenderSsrc(kSenderSsrc);

- EXPECT_TRUE(rr.AddReportBlock(rb));

+ rr.From(kSenderSsrc);

+ EXPECT_TRUE(rr.WithReportBlock(rb));

const size_t kRrLength = 8;

const size_t kReportBlockLength = 24;