webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes.h - Issue 2372713005: Revert of Unify rtcp packet setters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes.h

Issue 2372713005: Revert of Unify rtcp packet setters (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes.h

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes.h

index d9a952673341b94e80ce63a42841959fe2609d9c..19d5b42b5574116b3526cb3b1991fb25e3514bd8 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes.h

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes.h

@@ -36,7 +36,7 @@

// Parse assumes header is already parsed and validated.

bool Parse(const CommonHeader& packet);

- bool AddCName(uint32_t ssrc, std::string cname);

+ bool WithCName(uint32_t ssrc, const std::string& cname);

const std::vector<Chunk>& chunks() const { return chunks_; }