webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi.h - Issue 2372713005: Revert of Unify rtcp packet setters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi.h

Issue 2372713005: Revert of Unify rtcp packet setters (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi.h

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi.h

index 79b6acec3e8663fc20c69d21d536d245b6fd337f..49669f42bb9f644a3f7b1531492d1f050e5197ea 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi.h

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi.h

@@ -30,8 +30,8 @@

// Parse assumes header is already parsed and validated.

bool Parse(const CommonHeader& packet);

- void SetPayloadType(uint8_t payload);

- void SetPictureId(uint64_t picture_id);

+ void WithPayloadType(uint8_t payload);

+ void WithPictureId(uint64_t picture_id);

uint8_t payload_type() const { return payload_type_; }

uint64_t picture_id() const { return picture_id_; }