Style fixes in rtcp_packet/

Style fixes in rtcp_packet/

1. To make the files conform to chromium-style guidelines, and stop the compiler from complaing:
1.1. Move constructors out of .h file.
1.2. Move destructors out of .h file.
1.3. Move virtual functions out of .h file.
2. BlockLength() and Create() did not have consistent access modifiers in the various subclasses of RtcpPacket. Change the access level to public throughout.
3. Reorder BlockLength() and Create() where necessary, to reflect the order defined in the parent class (RtcpPacket).

BUG=None

Review-Url: https://codereview.webrtc.org/2937403002
Cr-Commit-Position: refs/heads/master@{#18633}
Committed: https://chromium.googlesource.com/external/webrtc/+/8fa21c49eff52b1848ff16483cc3a07af6acc7ca

[eladalon, 2017-06-16 12:42:37]

eladalon@webrtc.org changed reviewers:
+ danilchap@webrtc.org, nisse@webrtc.org

[eladalon, 2017-06-16 12:42:37]

PTAL

[danilchap, 2017-06-16 12:51:40]

lgtm
Nice!
Thank you for improving consistency in these classes.

https://codereview.webrtc.org/2937403002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/target_bitrate.cc (right):

https://codereview.webrtc.org/2937403002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/target_bitrate.cc:113: void
TargetBitrate::Create(uint8_t* buffer) const {
move it a bit more - after next (BlockLength) function

https://codereview.webrtc.org/2937403002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h (right):

https://codereview.webrtc.org/2937403002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h:47: protected:
private

[nisse-webrtc, 2017-06-16 12:51:57]

lgtm.

But be a bit more explicit in the descript, and say that the change is go make
BlockLength and Create public in all subclasses of RtcpPacket (if that's an
accurate description of your change).

[eladalon, 2017-06-16 13:14:54]

Description was changed from

==========
1. Conform to chromium-style rtcp_packet/ 2. Correct access modifier for
BlockLength() and Create()

BUG=None
==========

to

==========
Style fixes in rtcp_packet/

1. To make the files conform to chromium-style guidelines, and stop the compiler
from complaing:
1.1. Move constructors out of .h file.
1.2. Move destructors out of .h file.
1.3. Move virtual functions out of .h file.
2. BlockLength() and Create() did not have consistent access modifiers in the
various subclasses of RtcpPacket. Change the access level to public throughout.
3. Reorder BlockLength() and Create() where necessary, to reflect the order
defined in the parent class (RtcpPacket).

BUG=None
==========

[eladalon, 2017-06-16 13:15:04]

nisse@ - done.

https://codereview.webrtc.org/2937403002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/target_bitrate.cc (right):

https://codereview.webrtc.org/2937403002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/target_bitrate.cc:113: void
TargetBitrate::Create(uint8_t* buffer) const {
On 2017/06/16 12:51:40, danilchap wrote:
> move it a bit more - after next (BlockLength) function

Done.

https://codereview.webrtc.org/2937403002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h (right):

https://codereview.webrtc.org/2937403002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h:47: protected:
On 2017/06/16 12:51:40, danilchap wrote:
> private

Oops, how did that happen? Thanks for catching!

[eladalon, 2017-06-16 13:15:53]

The CQ bit was checked by eladalon@webrtc.org

[eladalon, 2017-06-16 13:15:54]

The patchset sent to the CQ was uploaded after l-g-t-m from nisse@webrtc.org,
danilchap@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2937403002/#ps20001 (title:
"CR response")

[commit-bot: I haz the power, 2017-06-16 13:16:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-16 14:07:48]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497618953517320,
"parent_rev": "6b826ef66dbdfd1688d0b64b751c7c1ec8fb85d5", "commit_rev":
"8fa21c49eff52b1848ff16483cc3a07af6acc7ca"}

[commit-bot: I haz the power, 2017-06-16 14:07:56]

Description was changed from

==========
Style fixes in rtcp_packet/

1. To make the files conform to chromium-style guidelines, and stop the compiler
from complaing:
1.1. Move constructors out of .h file.
1.2. Move destructors out of .h file.
1.3. Move virtual functions out of .h file.
2. BlockLength() and Create() did not have consistent access modifiers in the
various subclasses of RtcpPacket. Change the access level to public throughout.
3. Reorder BlockLength() and Create() where necessary, to reflect the order
defined in the parent class (RtcpPacket).

BUG=None
==========

to

==========
Style fixes in rtcp_packet/

1. To make the files conform to chromium-style guidelines, and stop the compiler
from complaing:
1.1. Move constructors out of .h file.
1.2. Move destructors out of .h file.
1.3. Move virtual functions out of .h file.
2. BlockLength() and Create() did not have consistent access modifiers in the
various subclasses of RtcpPacket. Change the access level to public throughout.
3. Reorder BlockLength() and Create() where necessary, to reflect the order
defined in the parent class (RtcpPacket).

BUG=None

Review-Url: https://codereview.webrtc.org/2937403002
Cr-Commit-Position: refs/heads/master@{#18633}
Committed:
https://chromium.googlesource.com/external/webrtc/+/8fa21c49eff52b1848ff16483...
==========

[commit-bot: I haz the power, 2017-06-16 14:07:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/8fa21c49eff52b1848ff16483...