Style fixes in rtcp_packet/

webrtc/modules/rtp_rtcp/source/rtcp_packet/target_bitrate.cc

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 47 matching lines @@
 //
 //  As an example of how S and T are intended to be used, VP8 simulcast will
 //  use a separate TargetBitrate message per stream, since they are transmitted
 //  on separate SSRCs, with temporal layers grouped by stream.
 //  If VP9 SVC is used, there will be only one SSRC, so each spatial and
 //  temporal layer combo used shall be specified in the TargetBitrate packet.
 
 TargetBitrate::TargetBitrate() {}
 TargetBitrate::~TargetBitrate() {}
 
-void TargetBitrate::Create(uint8_t* buffer) const {
-  buffer[0] = kBlockType;
-  buffer[1] = 0;  // Reserved.
-  const size_t block_length_words = (BlockLength() / 4) - 1;
-  ByteWriter<uint16_t>::WriteBigEndian(&buffer[2], block_length_words);
-
-  size_t index = kTargetBitrateHeaderSizeBytes;
-  for (const BitrateItem& item : bitrates_) {
-    buffer[index] = (item.spatial_layer << 4) | item.temporal_layer;
-    ByteWriter<uint32_t, 3>::WriteBigEndian(&buffer[index + 1],
-                                            item.target_bitrate_kbps);
-    index += kBitrateItemSizeBytes;
-  }
-}
-
 bool TargetBitrate::Parse(const uint8_t* block, uint16_t block_length) {
   if (block_length < 1) {
     LOG(LS_WARNING)
         << "Cannot parse TargetBitrate RTCP packet: Too little payload data ("
         << kTargetBitrateHeaderSizeBytes << " bytes needed, got "
         << block_length * 4 << ").";
     return false;
   }
 
   // Validate block header (should already have been parsed and checked).
@@ skipping 25 matching lines @@
   RTC_DCHECK_LE(target_bitrate_kbps, 0x00FFFFFFU);
   bitrates_.push_back(
       BitrateItem(spatial_layer, temporal_layer, target_bitrate_kbps));
 }
 
 const std::vector<TargetBitrate::BitrateItem>&
 TargetBitrate::GetTargetBitrates() const {
   return bitrates_;
 }
 
+void TargetBitrate::Create(uint8_t* buffer) const {

[danilchap, 2017/06/16 12:51:40]

move it a bit more - after next (BlockLength) function

[eladalon, 2017/06/16 13:15:04]

Done.

+  buffer[0] = kBlockType;
+  buffer[1] = 0;  // Reserved.
+  const size_t block_length_words = (BlockLength() / 4) - 1;
+  ByteWriter<uint16_t>::WriteBigEndian(&buffer[2], block_length_words);
+
+  size_t index = kTargetBitrateHeaderSizeBytes;
+  for (const BitrateItem& item : bitrates_) {
+    buffer[index] = (item.spatial_layer << 4) | item.temporal_layer;
+    ByteWriter<uint32_t, 3>::WriteBigEndian(&buffer[index + 1],
+                                            item.target_bitrate_kbps);
+    index += kBitrateItemSizeBytes;
+  }
+}
+
 size_t TargetBitrate::BlockLength() const {
   return kTargetBitrateHeaderSizeBytes +
          bitrates_.size() * kBitrateItemSizeBytes;
 }
 
 }  // namespace rtcp
 }  // namespace webrtc