Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h

Issue 2937403002: Style fixes in rtcp_packet/ (Closed)
Patch Set: CR response Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h
index 2e56e33286546e56a91ba7f07891b21c6a2952fb..1771e023ca5f68f774be00fa00a33eb6ed11a635 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h
@@ -24,8 +24,8 @@ class ExtendedJitterReport : public RtcpPacket {
static constexpr uint8_t kPacketType = 195;
static constexpr size_t kMaxNumberOfJitterValues = 0x1f;
- ExtendedJitterReport() {}
- ~ExtendedJitterReport() override {}
+ ExtendedJitterReport();
+ ~ExtendedJitterReport() override;
// Parse assumes header is already parsed and validated.
bool Parse(const CommonHeader& packet);
@@ -36,7 +36,8 @@ class ExtendedJitterReport : public RtcpPacket {
return inter_arrival_jitters_;
}
- protected:
+ size_t BlockLength() const override;
+
bool Create(uint8_t* packet,
size_t* index,
size_t max_length,
@@ -45,10 +46,6 @@ class ExtendedJitterReport : public RtcpPacket {
private:
static constexpr size_t kJitterSizeBytes = 4;
- size_t BlockLength() const override {
- return kHeaderLength + kJitterSizeBytes * inter_arrival_jitters_.size();
- }
-
std::vector<uint32_t> inter_arrival_jitters_;
};

Powered by Google App Engine
This is Rietveld 408576698