Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h

Issue 2937403002: Style fixes in rtcp_packet/ (Closed)
Patch Set: CR response Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_EXTENDED_JITTER_REPORT_H_ 11 #ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_EXTENDED_JITTER_REPORT_H_
12 #define WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_EXTENDED_JITTER_REPORT_H_ 12 #define WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_EXTENDED_JITTER_REPORT_H_
13 13
14 #include <vector> 14 #include <vector>
15 15
16 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet.h" 16 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet.h"
17 17
18 namespace webrtc { 18 namespace webrtc {
19 namespace rtcp { 19 namespace rtcp {
20 class CommonHeader; 20 class CommonHeader;
21 21
22 class ExtendedJitterReport : public RtcpPacket { 22 class ExtendedJitterReport : public RtcpPacket {
23 public: 23 public:
24 static constexpr uint8_t kPacketType = 195; 24 static constexpr uint8_t kPacketType = 195;
25 static constexpr size_t kMaxNumberOfJitterValues = 0x1f; 25 static constexpr size_t kMaxNumberOfJitterValues = 0x1f;
26 26
27 ExtendedJitterReport() {} 27 ExtendedJitterReport();
28 ~ExtendedJitterReport() override {} 28 ~ExtendedJitterReport() override;
29 29
30 // Parse assumes header is already parsed and validated. 30 // Parse assumes header is already parsed and validated.
31 bool Parse(const CommonHeader& packet); 31 bool Parse(const CommonHeader& packet);
32 32
33 bool SetJitterValues(std::vector<uint32_t> jitter_values); 33 bool SetJitterValues(std::vector<uint32_t> jitter_values);
34 34
35 const std::vector<uint32_t>& jitter_values() { 35 const std::vector<uint32_t>& jitter_values() {
36 return inter_arrival_jitters_; 36 return inter_arrival_jitters_;
37 } 37 }
38 38
39 protected: 39 size_t BlockLength() const override;
40
40 bool Create(uint8_t* packet, 41 bool Create(uint8_t* packet,
41 size_t* index, 42 size_t* index,
42 size_t max_length, 43 size_t max_length,
43 RtcpPacket::PacketReadyCallback* callback) const override; 44 RtcpPacket::PacketReadyCallback* callback) const override;
44 45
45 private: 46 private:
46 static constexpr size_t kJitterSizeBytes = 4; 47 static constexpr size_t kJitterSizeBytes = 4;
47 48
48 size_t BlockLength() const override {
49 return kHeaderLength + kJitterSizeBytes * inter_arrival_jitters_.size();
50 }
51
52 std::vector<uint32_t> inter_arrival_jitters_; 49 std::vector<uint32_t> inter_arrival_jitters_;
53 }; 50 };
54 51
55 } // namespace rtcp 52 } // namespace rtcp
56 } // namespace webrtc 53 } // namespace webrtc
57 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_EXTENDED_JITTER_REPORT_H_ 54 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_EXTENDED_JITTER_REPORT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698