Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.cc

Issue 2937403002: Style fixes in rtcp_packet/ (Closed)
Patch Set: CR response Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 42
43 if (packet.payload_size_bytes() < kCommonFeedbackLength) { 43 if (packet.payload_size_bytes() < kCommonFeedbackLength) {
44 LOG(LS_WARNING) << "Packet is too small to be a valid PLI packet"; 44 LOG(LS_WARNING) << "Packet is too small to be a valid PLI packet";
45 return false; 45 return false;
46 } 46 }
47 47
48 ParseCommonFeedback(packet.payload()); 48 ParseCommonFeedback(packet.payload());
49 return true; 49 return true;
50 } 50 }
51 51
52 size_t Pli::BlockLength() const {
53 return kHeaderLength + kCommonFeedbackLength;
54 }
55
52 bool Pli::Create(uint8_t* packet, 56 bool Pli::Create(uint8_t* packet,
53 size_t* index, 57 size_t* index,
54 size_t max_length, 58 size_t max_length,
55 RtcpPacket::PacketReadyCallback* callback) const { 59 RtcpPacket::PacketReadyCallback* callback) const {
56 while (*index + BlockLength() > max_length) { 60 while (*index + BlockLength() > max_length) {
57 if (!OnBufferFull(packet, index, callback)) 61 if (!OnBufferFull(packet, index, callback))
58 return false; 62 return false;
59 } 63 }
60 64
61 CreateHeader(kFeedbackMessageType, kPacketType, HeaderLength(), packet, 65 CreateHeader(kFeedbackMessageType, kPacketType, HeaderLength(), packet,
62 index); 66 index);
63 CreateCommonFeedback(packet + *index); 67 CreateCommonFeedback(packet + *index);
64 *index += kCommonFeedbackLength; 68 *index += kCommonFeedbackLength;
65 return true; 69 return true;
66 } 70 }
67 71
68 } // namespace rtcp 72 } // namespace rtcp
69 } // namespace webrtc 73 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.h ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/rapid_resync_request.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698