Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1817)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.h

Issue 2937403002: Style fixes in rtcp_packet/ (Closed)
Patch Set: CR response Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.h
index 59f3b617294d63322b2e9fe3baf0fa01b2c115d6..8d772d87fab7620770f982d1c3df591291b3a3a7 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.h
@@ -30,8 +30,8 @@ class Fir : public Psfb {
uint8_t seq_nr;
};
- Fir() {}
- ~Fir() override {}
+ Fir();
+ ~Fir() override;
// Parse assumes header is already parsed and validated.
bool Parse(const CommonHeader& packet);
@@ -41,7 +41,8 @@ class Fir : public Psfb {
}
const std::vector<Request>& requests() const { return items_; }
- protected:
+ size_t BlockLength() const override;
+
bool Create(uint8_t* packet,
size_t* index,
size_t max_length,
@@ -49,9 +50,7 @@ class Fir : public Psfb {
private:
static constexpr size_t kFciLength = 8;
- size_t BlockLength() const override {
- return kHeaderLength + kCommonFeedbackLength + kFciLength * items_.size();
- }
+
// SSRC of media source is not used in FIR packet. Shadow base functions.
void SetMediaSsrc(uint32_t ssrc);
uint32_t media_ssrc() const;
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698