Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.h

Issue 2937403002: Style fixes in rtcp_packet/ (Closed)
Patch Set: CR response Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_REMB_H_ 11 #ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_REMB_H_
12 #define WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_REMB_H_ 12 #define WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_REMB_H_
13 13
14 #include <vector> 14 #include <vector>
15 15
16 #include "webrtc/base/basictypes.h" 16 #include "webrtc/base/basictypes.h"
17 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/psfb.h" 17 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/psfb.h"
18 18
19 namespace webrtc { 19 namespace webrtc {
20 namespace rtcp { 20 namespace rtcp {
21 class CommonHeader; 21 class CommonHeader;
22 22
23 // Receiver Estimated Max Bitrate (REMB) (draft-alvestrand-rmcat-remb). 23 // Receiver Estimated Max Bitrate (REMB) (draft-alvestrand-rmcat-remb).
24 class Remb : public Psfb { 24 class Remb : public Psfb {
25 public: 25 public:
26 static constexpr uint8_t kFeedbackMessageType = 15; 26 static constexpr uint8_t kFeedbackMessageType = 15;
27 static constexpr size_t kMaxNumberOfSsrcs = 0xff; 27 static constexpr size_t kMaxNumberOfSsrcs = 0xff;
28 28
29 Remb() : bitrate_bps_(0) {} 29 Remb();
30 ~Remb() override {} 30 ~Remb() override;
31 31
32 // Parse assumes header is already parsed and validated. 32 // Parse assumes header is already parsed and validated.
33 bool Parse(const CommonHeader& packet); 33 bool Parse(const CommonHeader& packet);
34 34
35 bool SetSsrcs(std::vector<uint32_t> ssrcs); 35 bool SetSsrcs(std::vector<uint32_t> ssrcs);
36 void SetBitrateBps(uint64_t bitrate_bps) { bitrate_bps_ = bitrate_bps; } 36 void SetBitrateBps(uint64_t bitrate_bps) { bitrate_bps_ = bitrate_bps; }
37 37
38 uint64_t bitrate_bps() const { return bitrate_bps_; } 38 uint64_t bitrate_bps() const { return bitrate_bps_; }
39 const std::vector<uint32_t>& ssrcs() const { return ssrcs_; } 39 const std::vector<uint32_t>& ssrcs() const { return ssrcs_; }
40 40
41 protected: 41 size_t BlockLength() const override;
42
42 bool Create(uint8_t* packet, 43 bool Create(uint8_t* packet,
43 size_t* index, 44 size_t* index,
44 size_t max_length, 45 size_t max_length,
45 RtcpPacket::PacketReadyCallback* callback) const override; 46 RtcpPacket::PacketReadyCallback* callback) const override;
46 47
47 size_t BlockLength() const override {
48 return kHeaderLength + kCommonFeedbackLength + (2 + ssrcs_.size()) * 4;
49 }
50
51 private: 48 private:
52 static constexpr uint32_t kUniqueIdentifier = 0x52454D42; // 'R' 'E' 'M' 'B'. 49 static constexpr uint32_t kUniqueIdentifier = 0x52454D42; // 'R' 'E' 'M' 'B'.
53 50
54 // Media ssrc is unused, shadow base class setter and getter. 51 // Media ssrc is unused, shadow base class setter and getter.
55 void SetMediaSsrc(uint32_t); 52 void SetMediaSsrc(uint32_t);
56 uint32_t media_ssrc() const; 53 uint32_t media_ssrc() const;
57 54
58 uint64_t bitrate_bps_; 55 uint64_t bitrate_bps_;
59 std::vector<uint32_t> ssrcs_; 56 std::vector<uint32_t> ssrcs_;
60 }; 57 };
61 } // namespace rtcp 58 } // namespace rtcp
62 } // namespace webrtc 59 } // namespace webrtc
63 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_REMB_H_ 60 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_REMB_H_
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698