Chromium Code Reviews

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.h

Issue 2937403002: Style fixes in rtcp_packet/ (Closed)
Patch Set: CR response Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.h
index c3f1cab49110f6a2380722b9ee6405fb8e64dc96..e82f01c43f7ee44b698cd7c44df74589f6c9ab78 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.h
@@ -26,7 +26,7 @@ class Bye : public RtcpPacket {
static constexpr uint8_t kPacketType = 203;
Bye();
- ~Bye() override {}
+ ~Bye() override;
// Parse assumes header is already parsed and validated.
bool Parse(const CommonHeader& packet);
@@ -39,7 +39,8 @@ class Bye : public RtcpPacket {
const std::vector<uint32_t>& csrcs() const { return csrcs_; }
const std::string& reason() const { return reason_; }
- protected:
+ size_t BlockLength() const override;
+
bool Create(uint8_t* packet,
size_t* index,
size_t max_length,
@@ -48,8 +49,6 @@ class Bye : public RtcpPacket {
private:
static const int kMaxNumberOfCsrcs = 0x1f - 1; // First item is sender SSRC.
- size_t BlockLength() const override;
-
uint32_t sender_ssrc_;
std::vector<uint32_t> csrcs_;
std::string reason_;
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/app.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.cc » ('j') | no next file with comments »

Powered by Google App Engine