Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/app.h

Issue 2937403002: Style fixes in rtcp_packet/ (Closed)
Patch Set: CR response Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_packet/app.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/app.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/app.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/app.h
index 42a16c7a3a42dc1cd3e46ce20ccdaf449097ab36..1261e8456f9053b9c729807e3917e800e5f6ff55 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/app.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/app.h
@@ -21,8 +21,8 @@ class CommonHeader;
class App : public RtcpPacket {
public:
static constexpr uint8_t kPacketType = 204;
- App() : sub_type_(0), ssrc_(0), name_(0) {}
- ~App() override {}
+ App();
+ ~App() override;
// Parse assumes header is already parsed and validated.
bool Parse(const CommonHeader& packet);
@@ -38,7 +38,8 @@ class App : public RtcpPacket {
size_t data_size() const { return data_.size(); }
const uint8_t* data() const { return data_.data(); }
- protected:
+ size_t BlockLength() const override;
+
bool Create(uint8_t* packet,
size_t* index,
size_t max_length,
@@ -47,9 +48,6 @@ class App : public RtcpPacket {
private:
static constexpr size_t kAppBaseLength = 8; // Ssrc and Name.
static constexpr size_t kMaxDataSize = 0xffff * 4 - kAppBaseLength;
- size_t BlockLength() const override {
- return kHeaderLength + kAppBaseLength + data_.size();
- }
uint8_t sub_type_;
uint32_t ssrc_;
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_packet/app.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698