Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1070)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h

Issue 2937403002: Style fixes in rtcp_packet/ (Closed)
Patch Set: CR response Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h
index a02aad642227ee2415dff800bd13e00f6274a01e..8b32366e2427d2b0657be3cb02a161be9820fada 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h
@@ -27,8 +27,8 @@ class Tmmbn : public Rtpfb {
public:
static constexpr uint8_t kFeedbackMessageType = 4;
- Tmmbn() {}
- ~Tmmbn() override {}
+ Tmmbn();
+ ~Tmmbn() override;
// Parse assumes header is already parsed and validated.
bool Parse(const CommonHeader& packet);
@@ -37,18 +37,14 @@ class Tmmbn : public Rtpfb {
const std::vector<TmmbItem>& items() const { return items_; }
- protected:
+ size_t BlockLength() const override;
+
bool Create(uint8_t* packet,
size_t* index,
size_t max_length,
RtcpPacket::PacketReadyCallback* callback) const override;
private:
- size_t BlockLength() const override {
- return kHeaderLength + kCommonFeedbackLength +
- TmmbItem::kLength * items_.size();
- }
-
// Media ssrc is unused, shadow base class setter and getter.
void SetMediaSsrc(uint32_t ssrc);
uint32_t media_ssrc() const;
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/target_bitrate.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698