Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.h

Issue 2937403002: Style fixes in rtcp_packet/ (Closed)
Patch Set: CR response Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.h
index c62e505898ad2d6e0a1f524c9bb14f6dd4507164..0e39eb52e6aed025efb22f2cefd6da85af0a595e 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.h
@@ -26,7 +26,7 @@ class SenderReport : public RtcpPacket {
static constexpr uint8_t kPacketType = 200;
SenderReport();
- ~SenderReport() override {}
+ ~SenderReport() override;
// Parse assumes header is already parsed and validated.
bool Parse(const CommonHeader& packet);
@@ -55,7 +55,8 @@ class SenderReport : public RtcpPacket {
return report_blocks_;
}
- protected:
+ size_t BlockLength() const override;
+
bool Create(uint8_t* packet,
size_t* index,
size_t max_length,
@@ -65,11 +66,6 @@ class SenderReport : public RtcpPacket {
static const size_t kMaxNumberOfReportBlocks = 0x1f;
const size_t kSenderBaseLength = 24;
- size_t BlockLength() const override {
- return kHeaderLength + kSenderBaseLength +
- report_blocks_.size() * ReportBlock::kLength;
- }
-
uint32_t sender_ssrc_;
NtpTime ntp_;
uint32_t rtp_timestamp_;
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698