Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.h

Issue 2937403002: Style fixes in rtcp_packet/ (Closed)
Patch Set: CR response Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.h
index 09723ef949137ff2a175e70c6713e665c50dd6cb..cb34f370c5d93d99f278919836396c77dcb803f1 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.h
@@ -52,7 +52,8 @@ class ExtendedReports : public RtcpPacket {
return target_bitrate_;
}
- protected:
+ size_t BlockLength() const override;
+
bool Create(uint8_t* packet,
size_t* index,
size_t max_length,
@@ -61,11 +62,6 @@ class ExtendedReports : public RtcpPacket {
private:
static constexpr size_t kXrBaseLength = 4;
- size_t BlockLength() const override {
- return kHeaderLength + kXrBaseLength + RrtrLength() + DlrrLength() +
- VoipMetricLength() + TargetBitrateLength();
- }
-
size_t RrtrLength() const { return rrtr_block_ ? Rrtr::kLength : 0; }
size_t DlrrLength() const { return dlrr_block_.BlockLength(); }
size_t VoipMetricLength() const {

Powered by Google App Engine
This is Rietveld 408576698