Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h

Issue 2937403002: Style fixes in rtcp_packet/ (Closed)
Patch Set: CR response Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h
index 09aa0fef3b37e3a5ca7a7cb0f32742b4ea211cbb..2b8b190293942f26c499790a33a87a4eacb18776 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h
@@ -24,8 +24,8 @@ class CommonHeader;
class ReceiverReport : public RtcpPacket {
public:
static constexpr uint8_t kPacketType = 201;
- ReceiverReport() : sender_ssrc_(0) {}
- ~ReceiverReport() override {}
+ ReceiverReport();
+ ~ReceiverReport() override;
// Parse assumes header is already parsed and validated.
bool Parse(const CommonHeader& packet);
@@ -38,7 +38,8 @@ class ReceiverReport : public RtcpPacket {
return report_blocks_;
}
- protected:
+ size_t BlockLength() const override;
+
bool Create(uint8_t* packet,
size_t* index,
size_t max_length,
@@ -48,11 +49,6 @@ class ReceiverReport : public RtcpPacket {
static const size_t kRrBaseLength = 4;
static const size_t kMaxNumberOfReportBlocks = 0x1F;
- size_t BlockLength() const override {
- return kHeaderLength + kRrBaseLength +
- report_blocks_.size() * ReportBlock::kLength;
- }
-
uint32_t sender_ssrc_;
std::vector<ReportBlock> report_blocks_;
};

Powered by Google App Engine
This is Rietveld 408576698